Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout and retries #62

Merged
merged 5 commits into from
Feb 28, 2019
Merged

Add timeout and retries #62

merged 5 commits into from
Feb 28, 2019

Conversation

stefanprodan
Copy link
Member

This PR adds HTTP timeout and retries as optional fields to the Canary service spec.

  service:
    # container port
    port: 9898
    # Istio gateways (optional)
    gateways:
    - public-gateway.istio-system.svc.cluster.local
    # Istio virtual service host names (optional)
    hosts:
    - podinfo.example.com
    # HTTP match conditions (optional)
    match:
      - uri:
          prefix: /
    # HTTP rewrite (optional)
    rewrite:
      uri: /
    # timeout for HTTP requests (optional)
    timeout: 5s
    # retry policy when a HTTP request fails (optional)
    retries:
      attempts: 3

Fix #61

@codecov-io
Copy link

codecov-io commented Feb 27, 2019 •
edited
Loading

Codecov Report

Merging #62 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   55.45%   55.57%   +0.12%     
==========================================
  Files           9        9              
  Lines        1385     1389       +4     
==========================================
+ Hits          768      772       +4     
  Misses        481      481              
  Partials      136      136
Impacted Files Coverage Δ
pkg/controller/router.go 85.64% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1662479...90c71ec. Read the comment docs.

@stefanprodan stefanprodan merged commit f34739f into master Feb 28, 2019
@stefanprodan stefanprodan deleted the retries branch February 28, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support HTTP timeout and retries
2 participants
@stefanprodan @codecov-io